Skip to content

Conversation

@ryanbonial
Copy link
Member

@ryanbonial ryanbonial commented Dec 12, 2025

Description

Added support for liveEdit documents in the document actions API. This enhancement allows direct manipulation of documents that don't use the draft/published model, where edits are applied directly to the document.

The implementation:

  • Adds a liveEdit flag to the DocumentTypeHandle interface
  • Updates document action creators to handle liveEdit documents
  • Modifies document store logic to properly handle liveEdit documents
  • Updates permission checking to account for liveEdit documents
  • Adds comprehensive tests for liveEdit document operations

What to review

  • The handling of document IDs in action creators (no draft/published ID conversion for liveEdit documents)
  • The document store state selection logic for liveEdit documents
  • The permission checking logic for liveEdit documents
  • The implementation of CRUD operations for liveEdit documents in processActions.ts
  • Error handling for unsupported operations (publish/unpublish/discard) on liveEdit documents
  • Test coverage for all liveEdit document operations

Testing

Added comprehensive tests for all liveEdit document operations:

  • Creating liveEdit documents
  • Editing liveEdit documents
  • Deleting liveEdit documents
  • Error handling for unsupported operations (publish/unpublish/discard)
  • Error handling for invalid operations (creating existing documents, editing non-existent documents)

Fun gif

live

@ryanbonial ryanbonial requested a review from a team as a code owner December 12, 2025 19:35
@ryanbonial ryanbonial requested a review from mttdnt December 12, 2025 19:35
@vercel
Copy link

vercel bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
sdk-docs Ready Ready Preview, Comment Dec 13, 2025 0:59am
sdk-kitchensink-react Ready Ready Preview, Comment Dec 13, 2025 0:59am

@ryanbonial ryanbonial marked this pull request as draft December 12, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant