-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 4.1.6 support #5
Open
jihwans
wants to merge
16
commits into
santana:master
Choose a base branch
from
jihwans:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihwans
commented
Sep 20, 2014
- now supports 4.1.6
- nolog and nomig option added
PLEASE NOTE: I am in a rush so I am committing all the changes I need to have functional - rather than trying to be complete and systematic. In particular, I have not tested migrations because I don't use them in the application I have at hand. You have been warned.
(and restored the old format, more or less)
when join models without primary keys are used or primary keys cannot be found in the model anyway
- set prefetch_primary_key? to false to allow composite_primary_key auto-incrementation
- it now works with 4.1 (kinda..)
- It is in better shape now. - Successfully migrates an empty model...
Thanks @jihwans for the contribution. Please consider taking ownership of this project. I don't have the resources to maintain it any more. |
Okay, please send me over... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.