We no longer catch an error just to throw it again.#66
Open
BenMaer-Parkwood wants to merge 2 commits intosaoudrizwan:masterfrom
Open
We no longer catch an error just to throw it again.#66BenMaer-Parkwood wants to merge 2 commits intosaoudrizwan:masterfrom
BenMaer-Parkwood wants to merge 2 commits intosaoudrizwan:masterfrom
Conversation
craigrouse
added a commit
to craigrouse/Disk
that referenced
this pull request
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line
let url = try createURL(for: path, in: directory)was in a try catch block, such that if an error was thrown insidecreateURL(...), it would be caught in thecatchblock, only to be thrown again.The same issue was the case for the error thrown if
FileManager.default.fileExists(atPath: url.path)returned true. It would throw the error, then catch it, then throw it again.Seeing how there was no extra logic that was performed by the catch block, there was no reason to have that catch block.
This update makes changes so that the redundant catch and throw is avoided.