sap_hypervisor_node_preconfigure: Update until conditional for ansible-core 2.19 #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versions covered 2.9 to 2.19 Signed-off-by: Geetika Kapoor <[email protected]>
marcelmamula
changed the title
Contributor
|
@geetikakay Please follow convention for naming all pull requests and issues where we always start with role name, unless it affects whole repository. Same applies to description which needs to explain what changed and if and how it was tested. |
Collaborator
Author
|
@marcelmamula Hello, I have tested this patch with 2.19. I was looking at ansible supported versions and raised this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Made the until checks in the operator install tasks to use length comparisons so that it works consistent with all ansible versions.
Tested
These changes are tested with 2.19 and worked as expected