Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support of escape-output #17

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Remove support of escape-output #17

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1fb9dd
Remove support of `escape-output`
yalef Sep 25, 2023
740bcc2
Update changelog
yalef Sep 25, 2023
2e4eaeb
Update package version
yalef Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
History
=======

0.4.1 (2023-09-25)
------------------
* Remvoe ``escape_output`` due it's deprecation

0.4.0 (2023-09-11)
------------------
* Make possible to pass ``resource_kwargs`` in ViewSets
Expand Down
1 change: 0 additions & 1 deletion import_export_extensions/admin/mixins/export_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ def get_export_resource_kwargs(self, request, *args, **kwargs):
"""Provide escape settings to resource kwargs."""
kwargs = super().get_export_resource_kwargs(request, *args, **kwargs)
kwargs.update({
"escape_output": self.should_escape_output,
"escape_html": self.should_escape_html,
"escape_formulae": self.should_escape_formulae,
})
Expand Down
1 change: 0 additions & 1 deletion import_export_extensions/models/export_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ def _export_data_inner(self):
# file object (formats inherited from `BaseZipExport`)
export_data = self.file_format.export_data(
dataset=self.result,
escape_output=self.resource_kwargs.get("escape_output", False),
escape_html=self.resource_kwargs.get("escape_html", False),
escape_formulae=self.resource_kwargs.get("escape_formulae", False),
)
Expand Down