Make it working in multiple admin sites context #59
Conversation
|
Hi guys! |
| from django.apps import AppConfig | ||
| custom_admin_site = BaseAdminSite(name="custom_admin") |
There was a problem hiding this comment.
Seems like BaseAdminSite is not defined here
Please, add definition or import of BaseAdminSite to make the example more realistic (should be obvious it BaseAdminSite is existing class or defined by user)
| custom_admin_site = BaseAdminSite(name="custom_admin") | ||
| # ... | ||
| cutom_admin_site.register(ExportJob, ExportJobAdmin) |
There was a problem hiding this comment.
| cutom_admin_site.register(ExportJob, ExportJobAdmin) | |
| custom_admin_site.register(ExportJob, ExportJobAdmin) |
| resource_class = resources.BookResource | ||
| If you use multiple or custom admin site, register required models to them |
There was a problem hiding this comment.
Let's provide a link to the Django Documentation about multiple/custom admin site (https://docs.djangoproject.com/en/stable/ref/contrib/admin/#customizing-the-adminsite-class)
| def get_form(self, request: WSGIRequest, obj=None, **kwargs): | ||
| """Push admin site to form.""" | ||
| form = super().get_form(request, obj, **kwargs) | ||
|
|
||
| form.admin_site = self.admin_site | ||
| return form |
There was a problem hiding this comment.
Is it really required? Why?
Please try to answer questions why? rather than what does it do? in docstring
We also made some changes to the admin mixins, so this logic can probably be put into BaseCeleryImportExportAdminMixin. Please check the latest changes when you get back to work
| r"^celery-import/(?P<job_id>\d+)/progress/$", | ||
| self.admin_site.admin_view(self.import_job_progress_view), | ||
| name="import_job_progress", | ||
| name= "import_job_progress", |
There was a problem hiding this comment.
| name= "import_job_progress", | |
| name="import_job_progress", |
2 participants
TODO: