feat: add keycloak rolebindings #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udaltsovra
requested review from
dmitry-mightydevops,
DanilaKazakevich,
kseniyashaydurova,
MikhailKorol-saritasa,
populov,
roman-mightydevops,
SergeyDeminSaritasa,
luciano-buono and
rtest12
as code owners
udaltsovra
changed the title
MikhailKorol-saritasa
requested changes
Jan 17, 2025
| kind: RoleBinding | ||
| metadata: | ||
| name: keycloak:developer | ||
| namespace: prod |
There was a problem hiding this comment.
Shouldn't it be namespace: {{ .Release.Namespace }}?
udaltsovra
requested review from
MikhailKorol-saritasa,
dmitry-mightydevops and
luciano-buono
kseniyashaydurova
approved these changes
Jan 23, 2025
charts/rbac/Chart.yaml
Outdated
| @@ -6,7 +6,7 @@ type: application | |||
| # This is the chart version. This version number should be incremented each time you make changes | |||
| # to the chart and its templates, including the app version. | |||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | |||
| version: 0.1.12 | |||
| version: 0.1.13-dev.4 | |||
There was a problem hiding this comment.
Don't forget to change it on merge to have just 0.1.13
| @@ -43,5 +43,7 @@ subjects: | |||
| - apiGroup: rbac.authorization.k8s.io | |||
There was a problem hiding this comment.
Pls add comment where this group comes from?
| @@ -24,5 +24,8 @@ subjects: | |||
| - apiGroup: rbac.authorization.k8s.io | |||
| kind: Group | |||
| name: saritasa:sso:developers | |||
|
|
|||
| # this group is coming from keycloak sso via oidc | |||
| - apiGroup: rbac.authorization.k8s.io | |||
There was a problem hiding this comment.
- The same comment as for apps.yaml
- Pls specify comments in similar way everywhere
| @@ -31,5 +31,8 @@ subjects: | |||
| - apiGroup: rbac.authorization.k8s.io | |||
| kind: Group | |||
| name: saritasa:sso:developers | |||
| - apiGroup: rbac.authorization.k8s.io # this group is coming from keycloak sso via oidc | |||
There was a problem hiding this comment.
The same comment as for apps.yaml
| @@ -31,5 +31,8 @@ subjects: | |||
| - apiGroup: rbac.authorization.k8s.io | |||
| kind: Group | |||
| name: saritasa:sso:developers | |||
| - apiGroup: rbac.authorization.k8s.io # this group is coming from keycloak sso via oidc | |||
| kind: Group | |||
| name: developer | |||
|
|
|||
There was a problem hiding this comment.
Remove empty line pls
| @@ -24,5 +24,7 @@ subjects: | |||
| - apiGroup: rbac.authorization.k8s.io | |||
| kind: Group | |||
| name: saritasa:sso:developers | |||
|
|
|||
| - apiGroup: rbac.authorization.k8s.io # this group is coming from keycloak sso via oidc | |||
There was a problem hiding this comment.
The same comment as for apps.yaml
| - apiGroup: rbac.authorization.k8s.io | ||
| kind: User | ||
| name: saritasa-sso-devops | ||
|
|
||
| - apiGroup: rbac.authorization.k8s.io # this group is coming from keycloak sso via oidc |
There was a problem hiding this comment.
Pls add comments for other roles, where do they come from too
SergeyDeminSaritasa
approved these changes
Jan 24, 2025
KrawczowaKris
approved these changes
Jan 27, 2025
luciano-buono
approved these changes
Jan 28, 2025
MikhailKorol-saritasa
approved these changes
Feb 4, 2025
rtest12
approved these changes
Feb 4, 2025
DanilaKazakevich
approved these changes
Feb 5, 2025
| @@ -40,8 +40,10 @@ roleRef: | |||
| kind: Role | |||
| name: saritasa-developers-readonly-role | |||
| subjects: | |||
| - apiGroup: rbac.authorization.k8s.io | |||
| - apiGroup: rbac.authorization.k8s.io # this group is creating when sso stack applied in infra-v3 and when saritasa-sso module applied in infra-v2 | |||
There was a problem hiding this comment.
May be move comments to line above? Now it looks like it's a comment for this particular value, not the whole subject?
roman-mightydevops
approved these changes
Feb 6, 2025
SergeyDeminSaritasa
approved these changes
Jul 7, 2025
ilya-sonich
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Task: WRDOC-823
RoleBindingandClusterRoleBindingfor auth to cluster via keycloak in infra-v3Tested on
wrdoc-prodRelated PRs: