feat: extend image configuration options for WP apps #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-sonich
requested review from
DanilaKazakevich,
KrawczowaKris,
MikhailKorol-saritasa,
SergeyDeminSaritasa,
darliiin,
dmitry-mightydevops,
kseniyashaydurova,
luciano-buono,
rtest12,
sowecthal and
udaltsovra
as code owners
luciano-buono
approved these changes
Nov 6, 2025
| image: | ||
| repository: bitnamilegacy/wordpress | ||
| registry: {{ (.image).registry | default "registry-1.docker.io" }} |
Contributor
There was a problem hiding this comment.
Are the parentheses needed or can be removed in : (.image)
Contributor
Author
There was a problem hiding this comment.
I believe they are needed to allow users of the chart to omit the entire image mapping from their values and use our defaults (different from Bitnami's), but also leave the option of overriding some of the subfields
MikhailKorol-saritasa
approved these changes
Nov 7, 2025
SergeyDeminSaritasa
approved these changes
Nov 7, 2025
dmitry-mightydevops
approved these changes
Nov 7, 2025
udaltsovra
approved these changes
Nov 10, 2025
sowecthal
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Task: SD-373
Changes:
Related PR: