Remove explicit max_length limit in S3UploadURLField #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It causes issues with auto spec generation and validation. Since it can return full urls with auth query, which can easily pass a limit specified in model field(which is by default 100), it causes confusion for openapi specs validators.
TheSuperiorStanislav
requested review from
ron8mcr,
AndyGreenwell94,
OttoAndrey,
NikAzanov,
khangnguyen090999 and
KhoiCaoSaritasa
and removed request for
a team
OttoAndrey
approved these changes
Nov 15, 2024
| super().__init__(**kwargs) | ||
| if max_length is not None: |
There was a problem hiding this comment.
Dont we need test for it or it already has?
There was a problem hiding this comment.
It's copied from original implementation(drf's char field). I'm planning to setup coverage reporting similar to https://github.com/saritasa-nest/django-import-export-extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It causes issues with auto spec generation and validation.
Since it can return full urls with auth query, which can easily pass
a limit specified in model field(which is by default 100), it causes confusion for openapi specs validators.