Fix return type of QueryInterface::execute() #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-egerer
force-pushed
the
bugfix/fix-query-execute-return-type
branch
2 times, most recently
from
5bd227d to
82579a4
Compare
oliverklee
reviewed
Aug 12, 2024
stubs/QueryInterface.stub
Outdated
| @@ -6,12 +6,6 @@ namespace TYPO3\CMS\Extbase\Persistence; | |||
| */ | |||
| interface QueryInterface | |||
| { | |||
| /** | |||
| * @param bool $returnRawQueryResult | |||
| * @return \TYPO3\CMS\Extbase\Persistence\QueryResultInterface<ModelType>|array<string, mixed> | |||
There was a problem hiding this comment.
We have now updated the second type to be a list: b56227c
Do we then need changes to the DynamicReturnTypeExtension in this PR?
The `execute()` method has a boolean argument that defines if a raw result should be returned. This means that no object mapping is done but an array containing the result values is returned. It is now also supported to not just pass constant boolean values but a variable containing a boolean to the execute function. In this case it's not clear if a raw result or objects should be returned so we do now return a union type containing both.
sascha-egerer
force-pushed
the
bugfix/fix-query-execute-return-type
branch
from
82579a4 to
61cdb6d
Compare
|
As far as i can see this works now without any fruther changes. I'll merge this one now as it only adds additional tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The execute method has a boolean argument that
defines if a raw result should be returned.
This means that no object mapping is done but
an array containing the result values is returned.
It is now also supported to not just pass constant boolean values but a variable containing a boolean to the execute function. In this case it's not clear if a raw result or objects should be returned
so we do now return a union type containing both.