Fix invalid interface implementation by dynamic return type #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-egerer
force-pushed
the
bugfix/fix-object-storage-template
branch
from
16f8be9 to
efe1351
Compare
oliverklee
changed the title
ObjectStorage and QueryResultInterface template in stub
sascha-egerer
force-pushed
the
bugfix/fix-object-storage-template
branch
3 times, most recently
from
69c8e34 to
c829e53
Compare
sascha-egerer
changed the title
ObjectStorage and QueryResultInterface template in stub
The object storage offsetGet() is not compatible with the ArrayAccess interface but does some TYPO3 sepcific stuff. We can't set the correct return type via a stub as phpstan will complain that the return type is not compatible with the interface. To work around this we have to implement a dynamic return type extension again.
sascha-egerer
force-pushed
the
bugfix/fix-object-storage-template
branch
from
1b27922 to
45f4b20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object storage offsetGet() is not compatible with the
ArrayAccess interface but does some TYPO3 sepcific stuff.
We can't set the correct return type via a stub as phpstan
will complain that the return type is not compatible with
the interface.
To work around this we have to implement a dynamic return
type extension again.