Skip to content

feat: configurable serverName in SAS 9 #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

allanbowe
Copy link
Member

@allanbowe allanbowe commented Mar 10, 2025

Issue

Closes #1388

Intent

Server Name in SAS 9 should be configurable

Implementation

Updated SAS9-only logic in build.ts

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • Unit tests coverage has been increased and a new threshold is set.
  • All CI checks are green.
  • Development comments have been added or updated.
  • Development documentation coverage has been increased and a new threshold is set.
  • Reviewer is assigned.

Reviewer checks

  • Any new code is documented.

@allanbowe allanbowe linked an issue Mar 10, 2025 that may be closed by this pull request
@github-actions github-actions bot requested a review from medjedovicm March 10, 2025 15:45
Copy link

github-actions bot commented Mar 10, 2025

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 73.54% 3308/4498
🟡 Branches 60.55% 1311/2165
🟡 Functions 73.55% 670/911
🟢 Lines 82.61% 8459/10240

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 4f509c2

@allanbowe allanbowe merged commit e27010e into main Mar 18, 2025
2 checks passed
@allanbowe allanbowe deleted the 1388-make-sas9-servername-configurable branch March 18, 2025 11:22
Copy link

🎉 This PR is included in version 4.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make sas9 serverName configurable
2 participants