Skip to content

Removing esm package and bumping adapter #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 18, 2025
Merged

Removing esm package and bumping adapter #1390

merged 10 commits into from
Mar 18, 2025

Conversation

medjedovicm
Copy link
Member

@medjedovicm medjedovicm commented Mar 11, 2025

Intent

Bumping axios and @sasjs/utils in @sasjs/adapter makes CLI fail to parse modern syntax, since it was using esm package to load the CLI. We load the CLI now natively.

Pending

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • Unit tests coverage has been increased and a new threshold is set.
  • All CI checks are green.
  • Development comments have been added or updated.
  • Development documentation coverage has been increased and a new threshold is set.
  • Reviewer is assigned.

Reviewer checks

  • Any new code is documented.

@medjedovicm medjedovicm changed the title fix: removing esm package Removing esm package and bumping adapter Mar 11, 2025
Copy link

github-actions bot commented Mar 11, 2025

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 73.54% 3308/4498
🟡 Branches 60.55% 1311/2165
🟡 Functions 73.55% 670/911
🟢 Lines 82.58% 8440/10221

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 8977444

@sabhas sabhas marked this pull request as ready for review March 18, 2025 08:54
@allanbowe allanbowe merged commit 23aa346 into main Mar 18, 2025
2 checks passed
@allanbowe allanbowe deleted the bump-adapter branch March 18, 2025 09:46
Copy link

🎉 This PR is included in version 4.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants