Skip to content

fix(compile-web): added the ability to update link tags with rel='mod… #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2025

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented May 12, 2025

…ulepreload'

Issue

  • Compile web wasn't processing links with rel="modulepreload"

Implementation

  • added a function to extract links and rel=modulepreload and updated these link tag

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • Unit tests coverage has been increased and a new threshold is set.
  • All CI checks are green.
  • Development comments have been added or updated.
  • Development documentation coverage has been increased and a new threshold is set.
  • Reviewer is assigned.

Reviewer checks

  • Any new code is documented.

@github-actions github-actions bot requested a review from YuryShkoda May 12, 2025 11:21
@sasjs sasjs deleted a comment from github-actions bot May 12, 2025
@sabhas sabhas closed this May 12, 2025
@sabhas sabhas reopened this May 12, 2025
Copy link

github-actions bot commented May 12, 2025

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 73.57% 3315/4506
🟡 Branches 60.56% 1313/2168
🟡 Functions 73.74% 674/914
🟢 Lines 82.6% 8473/10258

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from a9b615d

@allanbowe allanbowe merged commit 2991d06 into main May 12, 2025
2 checks passed
@allanbowe allanbowe deleted the update-tags branch May 12, 2025 20:19
Copy link

🎉 This PR is included in version 4.12.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants