Skip to content

fix(viya): remove _debug=2 query parameter from deployed URLs #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

medjedovicm
Copy link
Member

Issue

Related to #1400

Intent

When you run the CBD command to deploy a Viya Stream app, the link printed in the terminal no longer includes the _debug=2 query parameter.

Implementation

  • Removed _debug=2 from the link printed in the terminal
  • Adjusted the cbd.spec.server.viya
  • Adjusted the run.spec.server.viya

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • Unit tests coverage has been increased and a new threshold is set.
  • [] All CI checks are green.
  • Development comments have been added or updated.
  • Development documentation coverage has been increased and a new threshold is set.
  • Reviewer is assigned.

Reviewer checks

  • Any new code is documented.

@github-actions github-actions bot requested a review from YuryShkoda May 21, 2025 07:22
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 73.56% 3313/4504
🟡 Branches 60.56% 1313/2168
🟡 Functions 73.74% 674/914
🟢 Lines 82.56% 8453/10238

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from c42a181

@allanbowe allanbowe merged commit 678688b into main May 21, 2025
3 checks passed
@allanbowe allanbowe deleted the viya-without-debug-param branch May 21, 2025 07:53
Copy link

🎉 This PR is included in version 4.12.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants