Add sass-parser support for variable declarations and @warn rules
#2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
force-pushed
the
parser-variable
branch
2 times, most recently
from
1c4ab3b
to
c43eaab
Compare
Goodwine
approved these changes
Oct 24, 2024
| (this.raws.flags?.value?.guarded === this.guarded && | ||
| this.raws.flags?.value?.global === this.global | ||
| ? this.raws.flags.raw | ||
| : (this.guarded ? ' !default' : '') + (this.global ? ' !global' : '')) + |
There was a problem hiding this comment.
Should there be documentation on the order in which these are rendered in the case where both are true but raws are empty or mismatch?
There was a problem hiding this comment.
Nah, I don't think documenting the default rendering is important when it's easy to control if you want to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.