Lazy load @parcel/watcher and fallback to chokidar #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
force-pushed
the
optional-parcel-watcher
branch
2 times, most recently
from
ec49bf8
to
684d3d6
Compare
ntkme
force-pushed
the
optional-parcel-watcher
branch
from
684d3d6
to
b7ee917
Compare
nex3
approved these changes
Oct 31, 2024
|
Actually, shouldn't this also set |
ntkme
force-pushed
the
optional-parcel-watcher
branch
from
e1f3d9c
to
3342ba8
Compare
Good call. Updated. |
…into optional-parcel-watcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on google/dart_cli_pkg#169
With this change, it no longer fails on loading
sasson CLI or API if@parcel/watcher's optional dependency is not available. The error about missing optional dependency is printed once per execution only if user actually used--watchflag on CLI, and then it fallbacks to chokidar for that whole execution.To test the new behavior, run
npm install --omit optionalto remove@parcel/watcher's optional depenency. Then runnode build/npm/sass.jsornode build/npm/sass.js --watch [...]to see it in action.I'm bumping dart-sdk requirement to 3.3.0 in order to use new
dart:js_interop, as the legacypackage:js_interop/js_interop.dartis giving me lots of troubles. E.g. cannot add non-static helper methods to an@JSclass etc.