Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ruby 3.3 #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

patbl
Copy link

@patbl patbl commented May 10, 2024

This is just to make it a bit easier to develop the gem. There aren't any changes to the lib directory or to trueskill.gemspec, so I think it'll continue working with old versions of Ruby.

patbl added 6 commits May 9, 2024 17:49
The warning was

    `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional
    semantics) or `be false` (for exact `== false` equality) instead.
    Called from
    /Users/pat/academia/libraries/trueskill/spec/saulabs/trueskill/factor_graph_spec.rb:119:in
    `block (6 levels) in <top (required)>'.
The warning was

	TrueSkillMatchers::EqualRating implements a legacy RSpec matcher protocol.
    For the current protocol you should expose the failure messages via the
    `failure_message` and `failure_message_when_negated` methods.  (Used from
    /Users/pat/academia/libraries/trueskill/spec/saulabs/trueskill/factor_graph_spec.rb:66:in
    `block (5 levels) in <top (required)>')
Ruby 3.3.1 is the latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant