Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent indentation in gitsheet.py #2069

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Oct 21, 2023

No description provided.

@cool-RR
Copy link
Contributor Author

cool-RR commented Oct 21, 2023

The CI failure isn't really related to my change, right?

@saulpw
Copy link
Owner

saulpw commented Oct 21, 2023

(Correct, the CI failure isn't your fault.)

Thanks for taking the effort to put this forward. This inconsistency is a result of minimizing the diffs in previous commit, in which I wanted to wrap the block in try/except, but wanted to emphasize in the diff/blame that the block of code itself was unchanged. Perhaps short-sighted, but then I do have an extensive history of myopia :)

Hopefully this makes the code at least a little easier to understand and extend in the future!

@saulpw saulpw merged commit bbcabb1 into saulpw:develop Oct 21, 2023
@cool-RR
Copy link
Contributor Author

cool-RR commented Oct 21, 2023

You're welcome.

At this point, I think that if I contributed to any random open-source project and the CI didn't fail on a problem unrelated to my code with an unclear error message, I would be surprised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants