[vds-] save hidden columns content also #2089 #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of 727fd33. Saving just the expressions of hidden columns isn't enough: an expression may depend on some data (value) from some hidden column, resulting in computation errors when loading back the .vds. Only saving the column metadata is also weird because they'd show in the columns sheet but result in empty columns values after setting back a width >0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of 727fd33.
Saving just the expressions of hidden columns isn't enough:
an expression may depend on some data (value) from some hidden column,
resulting in computation errors when loading back the .vds.
Only saving the column metadata is also weird because they'd show in
the columns sheet but result in empty columns values after setting
back a width >0.