[columns-] show sort direction on ColumnsSheet #2748
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The sort arrows look like this, to the left of the column names: |
saulpw
reviewed
May 20, 2025
| columns = [ | ||
| ColumnAttr('sheet', type=str), | ||
| ColumnAttr('name', help='rename the column on the source sheet'), | ||
| Column('name', getter=lambda c, r: (sort_disp_sym(c,r) or ' ') + r.name, help='rename the column on the source sheet'), |
There was a problem hiding this comment.
I see what you're going for here, it's clever. But the column value can't include the sort symbol, or it will make things difficult (for example editing the value). I think the idea from #2649 for a separate sort order column is the most workable.
There was a problem hiding this comment.
Oops yes, this breaks editing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to @frosencrantz's suggestion, here's a draft to start off a discussion. It makes column names one character wider to make room for the same sort symbol used for the column headers.