[graph-] accept refline input for case of multiple xcols #2856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user's refline value is interpreted as a value for the first xcol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2752.
To demonstrate, make a file
xcols.csv:Use
!to makex1andx2keycols . Make all columns numeric with#. Then plotywith.Add a refline with:
gx0Enter. On current visidata you'll get the errormust have 2 x values, had 1 values: 0.One commit in this PR turns off the check that gave that error.
The other commit changes the error checking when erasing x and y reflines. In current visidata, each axis was missing a check that was performed for the other one.