[main-] fix undo of first user alteration to a replayed cmdlog #2857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I replay a command log, like with
echo |vd -p -
then modify the sheeti
, and try to undo it withU
, I get a fail error:nothing to undo on current sheet
.That's because undo skips the first command in the log (after skipping any earlier options-setting commands), expecting it to be the command that created the sheet:
visidata/visidata/undo.py
Lines 44 to 46 in 641a5ea
That's true for most sheets, but the replayed cmdlog sheet does not have a sheet creation command, and it breaks the expectation.
This PR fixes the undo by inserting a
no-op
as the first command.