[palette-] when no choices match, show warning on Enter #2858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would accept the top matching choice, from the earlier matches to shorter input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input palette has a problem after hitting
EnterorSpacewhen the typed input has narrowed the matches to nothing. What gets chosen is the previous best match, shown earlier when there were matches.For example, hit
Spaceand hitzz, there are no matches displayed. When you hitEnter, what gets input isfreeze-col, the top match forz.This PR changes
Enterto reject the command with the warning:no choice matching zz.It changes
Spacein the input palette (when matching multiple inputs withmultiple=True, like for choosing aggregators after+) to keep the input and to let the user keep typing.