[mainloop-] for bindkey cmd, catch fail() from execCommand #2859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the situation when
bindkey
names a command that does not exist, like from this .visidatarc line:Sheet.bindkey('2', 'not-a-command')
When the user presses 2, visidata immediately exits with status -1, with no other output.
That's because
fail()
inexecCommand()
raisesExpectedException
which bubbles up pastrun()
andmain_vd()
tovd_cli()
:visidata/visidata/basesheet.py
Lines 203 to 204 in d499914
visidata/visidata/main.py
Lines 386 to 394 in d499914
This PR prevents the abrupt exit and shows the fail message:
no command for not-a-command