[html-] for # of header rows, use options.header #2879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some HTML tables, there is no first row having column names, and the first row holds data values. That ends up putting data values in the column header. Here's an example, where the columns get the names
1
and1.1
:It would be useful in these situations to use
--header=0
. That way I can interactively change theheader
value to0
and reload the sheet with^R
to move the data down by one row. This PR adds that ability to the HTML loader.One note, it differs from the tsv loader behavior when
options.header > 1
. The tsv loader joins the row values with the empty string''
, but the HTML loader joins them with'_'
. I didn't want to spend the time to fix that rare use case.