Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: share on windows & mac #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jycouet
Copy link

@jycouet jycouet commented Nov 8, 2024

I had the issue in another repo, this might help ;)

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for bsky-widget ready!

Name Link
🔨 Latest commit cf27f1f
🔍 Latest deploy log https://app.netlify.com/sites/bsky-widget/deploys/672e8ef7d33a7800083bc788
😎 Deploy Preview https://deploy-preview-4--bsky-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

// If I'm on windows it should be <br>, if not it should be \n
const lineBreak = navigator.userAgent.toLowerCase().includes("windows")
? "<br>"
: "\n";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the line breaks from mac also 🤔

I think it depends on whether you're opening from browser or app? like my current implementation seems to work for me on browser but breaks when I share from mobile app

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hummm, let's keep track bluesky-social/social-app#6133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants