NO_BRACES_IN_CONDITIONALS_AND_LOOPS fail within variable initialization block #5584
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # vim:ai et ts=2 sts=2 sw=2: | |
| name: Build and test | |
| on: | |
| pull_request: | |
| push: | |
| branches: | |
| - 'master' | |
| concurrency: | |
| # https://docs.github.com/en/actions/using-jobs/using-concurrency | |
| # The latest queued workflow is preferred; the ones already in progress get cancelled | |
| # Workflows on master branch shouldn't be cancelled, that's why they are identified by commit SHA | |
| group: ${{ github.ref == 'refs/heads/master' && format('{0}-{1}', github.workflow, github.sha) || format('{0}-{1}', github.workflow, github.ref) }} | |
| cancel-in-progress: true | |
| jobs: | |
| build_and_test_with_code_coverage: | |
| name: Build, test and upload code coverage | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| # required for correct codecov upload | |
| fetch-depth: 0 | |
| - name: Set up JDK 11 | |
| uses: actions/setup-java@v3 | |
| with: | |
| java-version: 11 | |
| distribution: temurin | |
| - name: Retrieve Kotlin version | |
| run: | | |
| kv=$(cat gradle/libs.versions.toml | grep '^kotlin =' | awk -F'[=]' '{print $2}' | tr -d '" ') | |
| echo KOTLIN_VERSION=$kv >> $GITHUB_ENV | |
| shell: bash | |
| - name: Cache konan | |
| uses: actions/cache@v3 | |
| with: | |
| path: ~/.konan | |
| key: ${{ runner.os }}-gradle-konan-${{ env.KOTLIN_VERSION }} | |
| - name: Build all | |
| uses: gradle/gradle-build-action@v2 | |
| with: | |
| gradle-version: wrapper | |
| gradle-home-cache-cleanup: true | |
| arguments: | | |
| build | |
| -x detekt | |
| --scan | |
| --build-cache | |
| - name: Upload gradle reports | |
| if: ${{ always() }} | |
| uses: actions/upload-artifact@v3 | |
| with: | |
| name: gradle-reports | |
| path: '**/build/reports/' | |
| retention-days: 1 | |
| - name: Upload diktat-ruleset jar | |
| uses: actions/upload-artifact@v3 | |
| with: | |
| name: diktat-ruleset | |
| path: diktat-ruleset/build/libs/diktat-*.jar | |
| # no need to store artifact longer, it is used only by dependant jobs | |
| retention-days: 1 | |
| - name: Upload diktat-cli jar | |
| uses: actions/upload-artifact@v3 | |
| with: | |
| name: diktat-cli | |
| path: diktat-cli/build/libs/diktat-cli-*.jar | |
| # no need to store artifact longer, it is used only by dependant jobs | |
| retention-days: 1 | |
| - name: Code coverage report | |
| uses: codecov/codecov-action@v3 | |
| with: | |
| fail_ci_if_error: false | |
| token: ${{ secrets.CODECOV_TOKEN }} | |
| run_diktat_from_CLI: | |
| name: Run diktat via CLI | |
| runs-on: ${{ matrix.os }} | |
| needs: build_and_test_with_code_coverage | |
| strategy: | |
| matrix: | |
| os: [ ubuntu-latest, windows-latest, macos-latest ] | |
| java-version: [8, 11] | |
| type: [ ktlint, cli ] | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Retrieve Ktlint version | |
| if: matrix.type == 'ktlint' | |
| run: | | |
| ktlint_version=$(cat gradle/libs.versions.toml | grep '^ktlint =' | awk -F'[=]' '{print $2}' | tr -d '" ') | |
| echo KTLINT_VERSION=$ktlint_version >> $GITHUB_ENV | |
| shell: bash | |
| - name: Setup environment | |
| if: matrix.type == 'ktlint' | |
| run: | | |
| curl -o ktlint -sSL https://github.com/pinterest/ktlint/releases/download/${{ env.KTLINT_VERSION }}/ktlint && chmod a+x ktlint | |
| java -version | |
| shell: bash | |
| - name: Download diktat jar | |
| if: matrix.type == 'ktlint' | |
| uses: actions/download-artifact@v3 | |
| with: | |
| name: diktat-ruleset | |
| - name: Generate run command using ktlint | |
| if: matrix.type == 'ktlint' | |
| run: | | |
| filename=$(ls -1 diktat-*.jar | head -n1) | |
| echo DIKTAT_RUN="java -jar ktlint -R \"$filename\"" >> $GITHUB_ENV | |
| shell: bash | |
| - name: Download diktat cli jar | |
| if: matrix.type == 'cli' | |
| uses: actions/download-artifact@v3 | |
| with: | |
| name: diktat-cli | |
| - name: Generate run command using cli | |
| if: matrix.type == 'cli' | |
| run: | | |
| filename=$(ls -1 diktat-cli-*.jar | head -n1) | |
| echo DIKTAT_RUN="java -jar \"$filename\"" >> $GITHUB_ENV | |
| shell: bash | |
| - name: Run diKTat from cli | |
| continue-on-error: true | |
| run: | | |
| ${{ env.DIKTAT_RUN }} 'examples/maven/src/main/kotlin/Test.kt' &>out.txt | |
| shell: bash | |
| - name: Check output | |
| run: | | |
| cat out.txt | |
| grep -E "\[VARIABLE_NAME_INCORRECT_FORMAT\]" out.txt | |
| rm out.txt | |
| shell: bash | |
| - name: Run diKTat from cli (absolute paths) | |
| continue-on-error: true | |
| if: ${{ runner.os == 'Linux' || runner.os == 'macOS' }} | |
| run: | | |
| ${{ env.DIKTAT_RUN }} "$PWD/examples/maven/src/main/kotlin/Test.kt" &>out.txt | |
| shell: bash | |
| - name: Run diKTat from cli on windows (absolute paths) | |
| continue-on-error: true | |
| if: runner.os == 'Windows' | |
| # cannot use '&>out.txt' since it's Windows | |
| run: | | |
| ${{ env.DIKTAT_RUN }} "%cd%/examples/maven/src/main/kotlin/Test.kt" > out.txt 2>&1 | |
| shell: cmd | |
| - name: Check output (absolute paths) | |
| run: | | |
| cat out.txt | |
| grep -E "\[VARIABLE_NAME_INCORRECT_FORMAT\]" out.txt | |
| rm out.txt | |
| shell: bash | |
| - name: Run diKTat from cli (glob paths, 1 of 4) | |
| continue-on-error: true | |
| run: | | |
| ${{ env.DIKTAT_RUN }} 'examples/maven/src/main/kotlin/*.kt' &>out.txt | |
| shell: bash | |
| - name: Check output (glob paths, 1 of 4) | |
| run: | | |
| cat out.txt | |
| grep -E "\[VARIABLE_NAME_INCORRECT_FORMAT\]" out.txt | |
| rm out.txt | |
| shell: bash | |
| - name: Run diKTat from cli (glob paths, 2 of 4) | |
| continue-on-error: true | |
| run: | | |
| ${{ env.DIKTAT_RUN }} 'examples/**/main/kotlin/*.kt' &>out.txt | |
| shell: bash | |
| - name: Check output (glob paths, 2 of 4) | |
| run: | | |
| cat out.txt | |
| grep -E "\[VARIABLE_NAME_INCORRECT_FORMAT\]" out.txt | |
| rm out.txt | |
| shell: bash | |
| - name: Run diKTat from cli (glob paths, 3 of 4) | |
| continue-on-error: true | |
| run: | | |
| ${{ env.DIKTAT_RUN }} 'examples/**/*.kt' &>out.txt | |
| shell: bash | |
| - name: Check output (glob paths, 3 of 4) | |
| run: | | |
| cat out.txt | |
| grep -E "\[VARIABLE_NAME_INCORRECT_FORMAT\]" out.txt | |
| rm out.txt | |
| shell: bash | |
| - name: Run diKTat from cli (glob paths, 4 of 4) | |
| continue-on-error: true | |
| run: | | |
| ${{ env.DIKTAT_RUN }} '**/*.kt' &>out.txt | |
| shell: bash | |
| - name: Check output (glob paths, 4 of 4) | |
| run: | | |
| cat out.txt | |
| grep -E "\[VARIABLE_NAME_INCORRECT_FORMAT\]" out.txt | |
| rm out.txt | |
| shell: bash | |
| build_and_test: | |
| name: Build and test | |
| runs-on: ${{ matrix.os }} | |
| strategy: | |
| # We need multiple builds to run even if the 1st one is failing, because | |
| # test failures may be OS-specific (or the tests themselves flaky). | |
| fail-fast: false | |
| matrix: | |
| os: [ ubuntu-latest, windows-latest, macos-latest ] | |
| # A possible workaround for <https://github.com/dorny/test-reporter/issues/168>. | |
| permissions: | |
| checks: write | |
| contents: write | |
| pull-requests: write | |
| statuses: write | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| # required for correct codecov upload | |
| fetch-depth: 0 | |
| - name: Set up JDK 11 | |
| uses: actions/setup-java@v3 | |
| with: | |
| java-version: 11 | |
| distribution: temurin | |
| - name: Retrieve Kotlin version | |
| run: | | |
| kv=$(cat gradle/libs.versions.toml | grep '^kotlin =' | awk -F'[=]' '{print $2}' | tr -d '" ') | |
| echo KOTLIN_VERSION=$kv >> $GITHUB_ENV | |
| shell: bash | |
| - name: Cache konan | |
| uses: actions/cache@v3 | |
| with: | |
| path: ~/.konan | |
| key: ${{ runner.os }}-gradle-konan-${{ env.KOTLIN_VERSION }} | |
| - name: Build all | |
| uses: gradle/gradle-build-action@v2 | |
| with: | |
| gradle-version: wrapper | |
| gradle-home-cache-cleanup: true | |
| arguments: | | |
| build | |
| -x detekt | |
| --scan | |
| --build-cache | |
| # This step needs a Git repository, so it's impossible to extract it | |
| # into a separate job (or, otherwise, we'd need to upload the content | |
| # of the whole `.git` folder as an artifact). | |
| - name: JUnit Tests (dorny/test-reporter@v1) | |
| uses: dorny/test-reporter@v1 | |
| if: ${{ always() }} | |
| with: | |
| name: JUnit Tests (${{ runner.os }}, dorny/test-reporter@v1) | |
| # Comma-separated values. | |
| path: "**/build/test-results/*/TEST-*.xml" | |
| reporter: java-junit | |
| # Ignore the "Resource not accessible by integration" error when a PR | |
| # originates from a non-collaborator. This is | |
| # <https://github.com/dorny/test-reporter/issues/168> which may be | |
| # potentially fixed with <https://github.com/dorny/test-reporter/pull/174>. | |
| continue-on-error: true | |
| - name: Upload test results | |
| uses: actions/upload-artifact@v3 | |
| if: ${{ always() }} | |
| with: | |
| name: xml-test-reports-${{ runner.os }} | |
| path: | | |
| **/build/test-results/*/TEST-*.xml | |
| retention-days: 1 | |
| - name: Upload gradle reports | |
| if: ${{ always() }} | |
| uses: actions/upload-artifact@v3 | |
| with: | |
| name: gradle-test-report-${{ matrix.os }} | |
| path: '**/build/reports/' | |
| retention-days: 1 | |
| - name: Code coverage report | |
| uses: codecov/codecov-action@v3 | |
| with: | |
| fail_ci_if_error: false | |
| token: ${{ secrets.CODECOV_TOKEN }} | |
| report: | |
| name: Publish JUnit test results | |
| if: ${{ always() }} | |
| needs: build_and_test | |
| runs-on: ${{ matrix.os }} | |
| strategy: | |
| matrix: | |
| os: [ windows-latest, macos-latest ] | |
| permissions: | |
| checks: write | |
| pull-requests: write | |
| steps: | |
| - uses: actions/download-artifact@v3 | |
| if: ${{ always() }} | |
| with: | |
| name: xml-test-reports-${{ runner.os }} | |
| # Uses Docker, that's why Linux-only. | |
| - name: JUnit Tests (EnricoMi/publish-unit-test-result-action@v2, Linux) | |
| uses: EnricoMi/publish-unit-test-result-action@v2 | |
| if: ${{ runner.os == 'Linux' }} | |
| with: | |
| check_name: JUnit Tests (${{ runner.os }}, EnricoMi/publish-unit-test-result-action@v2) | |
| junit_files: | | |
| **/target/*-reports/TEST-*.xml | |
| **/build/test-results/*/TEST-*.xml | |
| - name: JUnit Tests (EnricoMi/publish-unit-test-result-action@v2, Windows or Mac OS X) | |
| uses: EnricoMi/publish-unit-test-result-action/composite@v2 | |
| if: ${{ runner.os == 'Windows' || runner.os == 'macOS' }} | |
| with: | |
| check_name: JUnit Tests (${{ runner.os }}, EnricoMi/publish-unit-test-result-action@v2) | |
| junit_files: | | |
| **/target/*-reports/TEST-*.xml | |
| **/build/test-results/*/TEST-*.xml |