Fix: Use OSError.from_u32! instead of non-existent from_u64!.
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `from_u64!` function worked when `OSError` was an `:enum`, but it stopped being an enum when we needed to support using different values for certain errors on different platforms. This code has been broken since that change away from being an enum. This commit fixes the code by using the newly introduced `from_u32!` function that is now provided by `OSError`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
from_u64!function worked whenOSErrorwas an:enum, but it stopped being an enum when we needed to support using different values for certain errors on different platforms.This code has been broken since that change away from being an enum.
This commit fixes the code by using the newly introduced
from_u32!function that is now provided byOSError.