Fix networking setup in language runtime. #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for networking stuff to work as desired, we need to pass "true" for `init_network` in the `pony_language_features_init_t` passed to the `pony_start` call that starts the runtime. Without that, things like the `TCP` library won't work properly. (for example, on UNIX systems, a `SIGPIPE` may interrupt the program when writing to a TCP socket whose other ends is known by the kernel to have already closed).
jemc
force-pushed
the
fix/networking-setup-runtime
branch
from
9e4c22c to
f8578b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for networking stuff to work as desired, we need to pass "true" for
init_networkin thepony_language_features_init_tpassed to thepony_startcall that starts the runtime.Without that, things like the
TCPlibrary won't work properly. (for example, on UNIX systems, aSIGPIPEmay interrupt the program when writing to a TCP socket whose other ends is known by the kernel to have already closed).