Fix trait bitmap entries to correctly use 64-bit values #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(on 64-bit systems). Prior to this commit, there was a bug in which trait bitmap entries were truncated to 32 bits, causing bugs at run time when compiling large programs (with many reachable abstract types), where the subtypes weren't properly matching at runtime some supertypes.
These improvements made it easier to figure out the subtle bug that was fixed in the preceding commit, so they are getting included here on this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(on 64-bit systems).
Prior to this commit, there was a bug in which trait bitmap entries were truncated to 32 bits, causing bugs at run time when compiling large programs (with many reachable abstract types), where the subtypes weren't properly matching at runtime some supertypes.