Fix NTLM Auth in 3.0 #1031
Open
Fix NTLM Auth in 3.0 #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pcai Can you take a look at this when you get a moment? |
Contributor
|
The changes here look alright, the next step is to get the Faraday NTML Auth gem to be its finest. |
Contributor
Author
|
I may actually can this and expose logic for adding arbitrary middlewares to the resulting faraday clients, since that's a more general use case and solves things like digest auth as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
bugfix
Did you add tests for your changes?
No new tests were added, since ntlm isn't exactly testable off network, however i did modify some existing tests to make them compatible with these changes
Summary of changes
Trying to solve ntlm auth in the gem was proving to be entirely too complex, so i ended up extracting it to a new gem called faraday-ntlm_auth to get things working.