Extend behaviour for Maven classifiers and types #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test case with fixed version of plugin to demonstrate bug. Add test case with new version of plugin and expected success.
|
Travis build is a bit outdated and slightly dead :) |
jsuereth
approved these changes
Aug 4, 2020
|
Awesome. |
|
Hi, All. Travis CI seems to be not happy for some other reasons still. Is there any update? |
|
I guess because CI script tries to setup JDK6 and fails, since it's not supported anymore. |
|
Hi @gemelen, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
eed3si9n
reviewed
Aug 21, 2020
| @@ -0,0 +1,2 @@ | |||
| > parent/compile | |||
| > parent/Test/compile | |||
There was a problem hiding this comment.
This test failed during the auto publishing, so I had to disable it - https://travis-ci.org/github/sbt/sbt-pom-reader/jobs/719975106
[info] [info] Compiling 1 Java source to /tmp/sbt_fffa9bf1/can-handle-classifiers-and-types/common/module1/target/scala-2.12/test-classes ...
[info] [info] Done compiling.
[info] [info] Compiling 1 Scala source and 1 Java source to /tmp/sbt_fffa9bf1/can-handle-classifiers-and-types/core/target/scala-2.12/test-classes ...
[info] [error] /tmp/sbt_fffa9bf1/can-handle-classifiers-and-types/core/src/test/java/net/gemelen/example/core/JavaCoreTest.java:3:1: cannot find symbol
[info] [error] symbol: class MarkerTest
[info] [error] location: package net.gemelen.example.annotation
[info] [error] import net.gemelen.example.annotation.MarkerTest;
[info] [error] /tmp/sbt_fffa9bf1/can-handle-classifiers-and-types/core/src/test/java/net/gemelen/example/core/JavaCoreTest.java:7:1: cannot find symbol
[info] [error] symbol: class MarkerTest
[info] [error] location: class net.gemelen.example.core.JavaCoreTest
[info] [error] @MarkerTest
[info] [error] (core / Test / compileIncremental) javac returned non-zero exit code
[info] [error] Total time: 1 s, completed Aug 21, 2020 4:22:27 PM
[error] x reactor-pom / can-handle-classifiers-and-types 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changeset adds new behaviour in corner cases related to test artifacts for dependent modules.
Mostly it covers
test-jarcase more extensively than in previous attempts and translates such occurrences into Ivy's "test->test" configuration of module.Also, tests are provided to illustrate a bug and a successful solution (to some degree).
Minimalist test Maven project is based on Maven-side of Apache Spark build file.
Seems to cover #38 #37 and reiterates an idea from PR #14
Please review and comment, it'd be very nice to add this to plugin and replace Spark's fork with upstream (which is my current goal).