[1.x] Remove generateVersionFile from ZincBuildUtil
#1522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently
compiler-interfacejar on maven central is not reproducible. For example, https://repo1.maven.org/maven2/org/scala-sbt/compiler-interface/1.10.5/compiler-interface-1.10.5.jar contains a fileincrementalcompiler.version.properties, which contains a build timestamp.Fix
We remove the
incrementalcompiler.version.propertiesgeneration logic from Zinc.Note
sbtdoes useincrementalcompiler.version.propertiesin https://github.com/sbt/sbt/blob/1.10.x/zinc-lm-integration/src/main/scala/sbt/internal/inc/ZincComponentManager.scala, but sincesbtreads fromincrementalcompiler.version.properties, all other build tools don'tincrementalcompiler.version.propertiesuses analysis timestamp, which will be erased by default in zinc 2.xWe should still proceed with the removal of
incrementalcompiler.version.propertieson zinc side, and also remove the usage ofincrementalcompiler.version.propertiesonsbtside.