Skip to content

Conversation

@Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Dec 20, 2024

Issue

Currently compiler-interface jar on maven central is not reproducible. For example, https://repo1.maven.org/maven2/org/scala-sbt/compiler-interface/1.10.5/compiler-interface-1.10.5.jar contains a file incrementalcompiler.version.properties, which contains a build timestamp.

version=1.10.5
timestamp=20241130T035052

Fix

We remove the incrementalcompiler.version.properties generation logic from Zinc.

Note

sbt does use incrementalcompiler.version.properties in https://github.com/sbt/sbt/blob/1.10.x/zinc-lm-integration/src/main/scala/sbt/internal/inc/ZincComponentManager.scala, but since

  • Only sbt reads from incrementalcompiler.version.properties, all other build tools don't
  • Creation of incrementalcompiler.version.properties uses analysis timestamp, which will be erased by default in zinc 2.x

We should still proceed with the removal of incrementalcompiler.version.properties on zinc side, and also remove the usage of incrementalcompiler.version.properties on sbt side.

@Friendseeker Friendseeker changed the title Clean up generateVersionFile from ZincBuildUtil Clean up generateVersionFile from ZincBuildUtil Dec 20, 2024
@Friendseeker Friendseeker marked this pull request as ready for review December 20, 2024 09:19
@Friendseeker Friendseeker changed the title Clean up generateVersionFile from ZincBuildUtil [1.x] Clean up generateVersionFile from ZincBuildUtil Dec 20, 2024
@Friendseeker Friendseeker changed the title [1.x] Clean up generateVersionFile from ZincBuildUtil [1.x] Remove generateVersionFile from ZincBuildUtil Dec 20, 2024
@eed3si9n
Copy link
Member

This is probably a good idea, but we need to remove the usage side first before breaking sbt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants