Skip to content

update mima setting #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

update mima setting #1577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/run-ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ sbt -Dfile.encoding=UTF-8 \
scalafmtCheckAll \
scalafmtSbtCheck \
Test/compile \
mimaReportBinaryIssues \
doc \
crossTestBridges \
test \
Expand Down
29 changes: 2 additions & 27 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,34 +8,9 @@ def internalPath = zincRootPath / "internal"

def mimaSettings: Seq[Setting[?]] = Seq(
mimaPreviousArtifacts := {
val pre140 = Set(
"1.0.0",
"1.0.1",
"1.0.2",
"1.0.3",
"1.0.4",
"1.0.5",
"1.1.0",
"1.1.1",
"1.1.2",
"1.1.3",
"1.2.0",
"1.2.1",
"1.2.2",
"1.3.0",
val versions: Set[String] = Set(
"2.0.0-M6"
Comment on lines +11 to +12
Copy link
Member

@eed3si9n eed3si9n Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the compiler bridges are now maintained outside, I think we should check the binary compatibility of the compiler interface, though technically since it's an implementation detail, and I don't promise any compatibility of it.

)
val post140: Set[String] = Set(
"1.4.0",
"1.5.0",
"1.6.0",
"1.7.0",
"1.8.0",
"1.9.0",
"1.10.0",
)
val versions =
if (scalaVersion.value.startsWith("2.12.")) pre140 ++ post140
else post140
val cross = if (crossPaths.value) CrossVersion.binary else CrossVersion.disabled
versions.map(version => organization.value %% moduleName.value % version cross cross)
},
Expand Down
Loading