ERC-721 extension #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

damianmarti merged 6 commits into erc-721 from erc-721-init

Dec 22, 2024

Member

damianmarti commented Oct 18, 2024

An ERC-721 extension to demonstrate how to integrate an ERC-721 NFT.


          ERC-721 extension

ab3f959

damianmarti requested review from Pabl0cks and carletex

October 18, 2024 13:51

damianmarti changed the base branch from main to erc-721

October 18, 2024 13:51

Pabl0cks reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/components/AllNfts.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/components/AllNfts.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/components/AllNfts.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/components/AllNfts.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/components/AllNfts.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/components/AllNfts.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/components/MyNfts.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/components/MyNfts.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/page.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/page.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/page.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/page.tsx Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/README.md.args.mjs Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

extension/README.md.args.mjs Outdated Show resolved Hide resolved

Pabl0cks reviewed

View reviewed changes

Contributor

Pabl0cks left a comment •

edited

Loading

gj Damu! Extension is working nicely, just added some comments and nitpicks, almost all of them are just copys, messages or variable names.

Pabl0cks reviewed

View reviewed changes

extension/packages/nextjs/app/erc721/page.tsx Outdated Show resolved Hide resolved

Member Author

damianmarti commented Oct 22, 2024

gj Damu! Extension is working nicely, just added some comments and nitpicks, almost all of them are just copys, messages or variable names.

Thanks!!


          Improvements from the PR review

657c245

damianmarti requested a review from Pabl0cks

October 22, 2024 14:53

Pabl0cks added 2 commits

December 22, 2024 01:04


          Fix EIP link

a52ec67


          Fix EIP link in template

4d5e01a

Pabl0cks added 2 commits

December 22, 2024 01:07


          Add ERC-721 Enumerable extension section

a3f2383


          Add missing words

0fd3bf6

Pabl0cks approved these changes

View reviewed changes

Contributor

Pabl0cks left a comment

Sorry Damu totally missed your updates until this week. All updates look good to me 🙌

Only pushed some tweaks on the Readme/description from ERC721 page, to make them all consistant.

Feel totally free to undo any changes or tweak them however you see them better! Was just quicker to push than report :)

Member Author

damianmarti commented Dec 22, 2024

Sorry Damu totally missed your updates until this week. All updates look good to me 🙌

Only pushed some tweaks on the Readme/description from ERC721 page, to make them all consistant.

Feel totally free to undo any changes or tweak them however you see them better! Was just quicker to push than report :)

Thanks @Pabl0cks for the review and the tweaks!!

damianmarti merged commit 921f189 into erc-721

damianmarti deleted the erc-721-init branch

December 22, 2024 14:38

Member Author

damianmarti commented Dec 22, 2024

Merged this. I will add the extension to the extension's source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet