Skip to content

ERC-721 extension #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 22, 2024
Merged

ERC-721 extension #33

merged 6 commits into from
Dec 22, 2024

Conversation

damianmarti
Copy link
Member

An ERC-721 extension to demonstrate how to integrate an ERC-721 NFT.

localhost_3000_erc721

@damianmarti damianmarti changed the base branch from main to erc-721 October 18, 2024 13:51
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Pabl0cks Pabl0cks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj Damu! Extension is working nicely, just added some comments and nitpicks, almost all of them are just copys, messages or variable names.

Pabl0cks
Pabl0cks reviewed Oct 22, 2024
View reviewed changes
@damianmarti
Copy link
Member Author

gj Damu! Extension is working nicely, just added some comments and nitpicks, almost all of them are just copys, messages or variable names.

Thanks!!

@damianmarti damianmarti requested a review from Pabl0cks October 22, 2024 14:53
Pabl0cks
Pabl0cks approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry Damu totally missed your updates until this week. All updates look good to me 🙌

Only pushed some tweaks on the Readme/description from ERC721 page, to make them all consistant.

Feel totally free to undo any changes or tweak them however you see them better! Was just quicker to push than report :)

@damianmarti
Copy link
Member Author

Sorry Damu totally missed your updates until this week. All updates look good to me 🙌

Only pushed some tweaks on the Readme/description from ERC721 page, to make them all consistant.

Feel totally free to undo any changes or tweak them however you see them better! Was just quicker to push than report :)

Thanks @Pabl0cks for the review and the tweaks!!

@damianmarti damianmarti merged commit 921f189 into erc-721 Dec 22, 2024
@damianmarti damianmarti deleted the erc-721-init branch December 22, 2024 14:38
@damianmarti
Copy link
Member Author

Merged this. I will add the extension to the extension's source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pabl0cks Pabl0cks Pabl0cks approved these changes

@carletex carletex Awaiting requested review from carletex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damianmarti @Pabl0cks