-
Notifications
You must be signed in to change notification settings - Fork 9
Possibility to pass global variables #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
technophile-04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@technophile-04 I hope this is what you expected to see when created #331
YESS! This is amazing I was just playing around it for a bit and working great! Will go through the code once, but this is working great! Thanks Rinat!
… into pass-sf-template
technophile-04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Tysm @rin-st!
Just one thing, I think we can also use the new solidityFramework arg in the below file?
create-eth/templates/base/packages/nextjs/app/blockexplorer/address/[address]/page.tsx.template.mjs
Line 3 in b2a0d70
| const contents = ({ chainName, artifactsDirName }) => ` |
|
good point, updated! |
technophile-04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! TYSM 🙏
Slightly updated the code of #331 (I used the same branch), see difference in the 7f54b7d. And now in arguments we can use functions with global variables as parameters, for example
To test
Read the example extension scaffold-eth/create-eth-extensions#104
Create the instance using hardhat or foundry
Check Readme and page.tsx of the instance
@technophile-04 I hope this is what you expected to see when created #331