-
Notifications
You must be signed in to change notification settings - Fork 9
Add drizzle-neon as curated extension #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently, See also and create-eth/src/dev/create-extension.ts Line 168 in 11213a6
which is not true anymore since we added argument to the env file https://github.com/scaffold-eth/create-eth/blob/main/templates/base/packages/nextjs/.env.example.template.mjs |
|
ok, thanks, Rinat!! We can add the I think the extension is ready then. |
I think the only reason we didn't add possibility to change it because we didn't need it yet. Created the issue #352
Lgtm! |
|
Thanks @carletex and @rin-st for review 🙌 Just pused the commits to allow Merging this! |
|
Thanks Shiv! <3 |
Pushed the extensions here: https://github.com/scaffold-eth/create-eth-extensions/tree/drizzle-neon
Pushed some README tweaks, but couldn't make the .gitignore work. I think I'm missing something. I created a
.gitignore.args.mjsin theextension/folder and added this for test:export const contents = "data";I can see the generated
-devfile when running locally:but the root gitignore remains unchanged. What am I doing wrong?
Thanks!!