Remove trailing comments in parsed SBT module version #3477
+29
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At $work we recently noticed that Scala Steward was not updating dependencies that have trailing comments like
these we're workarounding them by placing the comments elsewhere:
but I think this can be easily avoided by changing the regex like in this PR.
I don't have any idea if this impacts anything else in the code (tests are green at least locally), so let's discuss it because I think the current behavior is not the expected one 🙏🏽