-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic dev deployment on push #7657
base: master
Are you sure you want to change the base?
Conversation
could we have this maybe only if the PR is ready for review? |
Done now. As discussed after the presentation, it is not exactly clear how to proceed here. i.e. require a label, what should be the default, is draft status relevant? |
I like the idea of a |
Yes, it is possible to run a GitHub action on a label change (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request). However, this would then be a GitHub action and not a circleCI action. Another question would be when this should run:
|
Maybe it would be best to just check at the end of every CircleCI run whether the label is present and deploy/update accordingly. Removing deployments would still be manual. |
Would it make things easier to use the |
e9152e6
to
7f2603a
Compare
7f2603a
to
c23f1a9
Compare
Currently working on editing this comment, but the Github Token does not alow for that.
https://___.webknossos.xyz
(Please delete unneeded items, merge only when none are left open)