-
Notifications
You must be signed in to change notification settings - Fork 1
[scalar-manager] Support mounting user created secret #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @kota2and3kan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Scalar Manager's deployment capabilities by allowing users to securely inject sensitive configuration data, such as credentials, into the Scalar Manager API pods. By integrating Kubernetes Secrets via a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new feature to mount a user-created secret into the Scalar Manager API pod, which is a valuable addition for managing sensitive data like credentials. The implementation is clean and consistent with existing patterns in the Helm charts. My review includes one suggestion to improve the robustness of the Helm template by using the quote function, which is a recommended best practice.
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
thongdk8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR adds a new feature, which mounts a user created secret on a pod. You can specify the secret name in
scalarManager.api.secretName.Now, users can set credentials via secret (environment variables) in
application.properties.Basically, this new feature is the same implementation as ScalarDB Cluster's feature.
Please take a look!
Related issues and/or PRs
N/A
Changes made
scalarManager.api.secretName.envFromon the Scalar Manager API container.Checklist
Additional notes (optional)
You can use this new feature as follows:
Set
scalarManager.api.secretNameand set environment variable name inapplication.properties.Create a secret resource.
Deploy Scalar Manager.
Check if the environment variables are set in the container.
Check if the values are applied via environment variables (the admin user is registered in the backend database).
Release notes
N/A