-
Notifications
You must be signed in to change notification settings - Fork 1
Add kubeVersion and annotations for Red Hat Ecosystem Catalog #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add kubeVersion and annotations for Red Hat Ecosystem Catalog #323
Conversation
Summary of ChangesHello @kota2and3kan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the ScalarDB Cluster Helm chart by incorporating essential metadata, specifically Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds kubeVersion and annotations to the Chart.yaml file, which are required for listing the chart on the Red Hat Ecosystem Catalog. The README.md is also updated to reflect the Kubernetes version requirement. The changes are clear and well-motivated. My review includes a suggestion to add other required annotations to ensure full compliance with the Red Hat certification policy.
Description
This PR adds two metadata,
kubeVersionandannotations, in theChart.yamlfile.This metadata is required to list this chart on Red Hat Ecosystem Catalog.
Please take a look!
Related issues and/or PRs
N/A
Changes made
kubeVersionandannotationsin theChart.yamlfile.Checklist
Additional notes (optional)
I verified this updated chart by using chart-verifier.
As a result, I can see the metadata requirements passed the verification as follows:
Release notes
N/A