Skip to content

Remove serializable strategy config #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

brfrn169
Copy link
Contributor

Description

This PR removes the serializable strategy config, as it was removed in scalar-labs/scalardb#2597.

Related issues and/or PRs

Changes made

  • Removed the serializable strategy config.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@brfrn169 brfrn169 self-assigned this Apr 28, 2025
@brfrn169 brfrn169 force-pushed the remove-serializable_strategy-config branch from f1a1bc0 to 3fa2201 Compare April 28, 2025 06:41
@brfrn169 brfrn169 force-pushed the remove-serializable_strategy-config branch from 3fa2201 to 4fc40a4 Compare April 28, 2025 06:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@brfrn169 brfrn169 requested a review from inv-jishnu April 28, 2025 09:42
@Torch3333 Torch3333 requested a review from Copilot April 30, 2025 07:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (7)
  • scalardb/src/scalardb/db_extend.clj: Language not supported
  • scalardb/src/scalardb/runner.clj: Language not supported
  • scalardb/test/scalardb/db_extend_test.clj: Language not supported
  • scalardb/test/scalardb/elle_append_2pc_test.clj: Language not supported
  • scalardb/test/scalardb/elle_append_test.clj: Language not supported
  • scalardb/test/scalardb/elle_write_read_2pc_test.clj: Language not supported
  • scalardb/test/scalardb/elle_write_read_test.clj: Language not supported

Copy link

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@inv-jishnu inv-jishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you.

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@yito88 yito88 merged commit d5631c5 into master May 2, 2025
3 checks passed
@yito88 yito88 deleted the remove-serializable_strategy-config branch May 2, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants