Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala style threadsafe #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smanikim
Copy link

@smanikim smanikim commented Jan 5, 2018

  • Upgraded libs to remove non-threadSafe dependency
  • Marked as thread safe

@smanikim
Copy link
Author

smanikim commented Jan 5, 2018

@matthewfarwell Regarding communication on scalastyle/scalastyle#291 (comment), I am trying to start it now. Test failing for JAVA_HOME

@matthewfarwell
Copy link
Member

I'm happy to do this. Was there a reason why you changed the dependencies?

@smanikim
Copy link
Author

@matthewfarwell those dependencies were not thread-safe, so had to upgrade them.
By the way, it has one commit left which is yet to be published.

@matthewfarwell
Copy link
Member

@smanikim Hi, could you tell me what the status of this is please? I want to do a release soon, and it would be nice if this were included.

@smanikim
Copy link
Author

@matthewfarwell could you check into build failure
Once that is fixed, there was some other local changes which I can push

@smanikim
Copy link
Author

smanikim commented Apr 9, 2018

@matthewfarwell reminder

@smanikim smanikim changed the title Manik vikas scala style threadsafe scala style threadsafe May 9, 2018
@smanikim
Copy link
Author

smanikim commented May 9, 2018

@matthewfarwell another reminder :)

@smanikim
Copy link
Author

smanikim commented May 9, 2018

@dasbh as well

@ScrapCodes
Copy link
Member

Can you explain, the dependencies change?
Is the change still valid? Is this PR ready to go from your side?

@smanikim
Copy link
Author

I don't remember it by heart. But looking at changes, it should be good

@Jenya95
Copy link

Jenya95 commented Dec 26, 2022

Hi! Will this PR be merged in the near future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants