-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scala style threadsafe #16
base: master
Are you sure you want to change the base?
scala style threadsafe #16
Conversation
smanikim
commented
Jan 5, 2018
•
edited
Loading
edited
- Upgraded libs to remove non-threadSafe dependency
- Marked as thread safe
@matthewfarwell Regarding communication on scalastyle/scalastyle#291 (comment), I am trying to start it now. Test failing for JAVA_HOME |
I'm happy to do this. Was there a reason why you changed the dependencies? |
@matthewfarwell those dependencies were not thread-safe, so had to upgrade them. |
@smanikim Hi, could you tell me what the status of this is please? I want to do a release soon, and it would be nice if this were included. |
@matthewfarwell could you check into build failure |
@matthewfarwell reminder |
@matthewfarwell another reminder :) |
@dasbh as well |
Can you explain, the dependencies change? |
I don't remember it by heart. But looking at changes, it should be good |
Hi! Will this PR be merged in the near future? |