ScalastyleConfiguration without XML#56
Open
andrelfpinto wants to merge 4 commits intoscalastyle:masterfrom
Open
ScalastyleConfiguration without XML#56andrelfpinto wants to merge 4 commits intoscalastyle:masterfrom
andrelfpinto wants to merge 4 commits intoscalastyle:masterfrom
Conversation
Configuring `ScalastyleConfiguration` by hand in Scala instead of parsing the XML configuration file is "type-safer". This renames `scalastyleConfig` `settingKey[File]` to `scalastyleConfigFile` and creates a `scalastyleConfig` `settingKey[Option[ScalastyleConfiguration]]` that can be used in the `build.sbt` file.
This changes the sbt setting `scalastyleConfig` to `scalastyleConfigFile` in the tests.
This renames `scalastyle-config` tests to `scalastyle-config-file`.
This adds tests to `scalastyleConfig` (which now do not use XML config file).
|
I find the premise of this PR very nice. It's sad that it got left to bit-rot. |
Contributor
Author
|
Actually, I just (earlier today) rebased the scalastyle PR that this PR depends on. Let's hope it gets accepted for this one be revived. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuring
ScalastyleConfigurationby hand in Scala instead of parsing the XML configuration file is "type-safer".This renames
scalastyleConfigsettingKey[File]toscalastyleConfigFileand creates ascalastyleConfigsettingKey[Option[ScalastyleConfiguration]]that can be used in thebuild.sbtfile.Depends on scalastyle PR #223.