Skip to content

feat(instance): support legacy b_ssd in server creation #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Apr 16, 2025

No description provided.

@Codelax Codelax requested a review from a team as a code owner April 16, 2025 09:57
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Apr 16, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.51%. Comparing base (5bf53e0) to head (a2e33e9).
Report is 592 commits behind head on master.

Files with missing lines Patch % Lines
...spaces/instance/v1/custom_server_create_builder.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (a2e33e9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (a2e33e9)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4672       +/-   ##
===========================================
- Coverage   75.45%   55.51%   -19.94%     
===========================================
  Files         202      308      +106     
  Lines       44323    78586    +34263     
===========================================
+ Hits        33444    43630    +10186     
- Misses       9653    33556    +23903     
- Partials     1226     1400      +174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -565,6 +565,8 @@ func NewVolumeBuilder(zone scw.Zone, flagV string) (*VolumeBuilder, error) {
vb.VolumeType = instance.VolumeVolumeTypeLSSD
case "sbs", "b", "block":
vb.VolumeType = instance.VolumeVolumeTypeSbsVolume
case "b_ssd":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a feature which will be deprecated in the coming weeks (April 30th)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants