Skip to content

Conversation

@mauritsderuiter95
Copy link
Contributor

close #3592

Proposal as described here: #3592 (comment)

Copilot AI review requested due to automatic review settings January 12, 2026 14:41
@mauritsderuiter95 mauritsderuiter95 requested a review from a team as a code owner January 12, 2026 14:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions bot added the domain Domains issues, bugs and feature requests label Jan 12, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 45.83333% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 2.33%. Comparing base (342cbc6) to head (e5d18ed).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/services/domain/record.go 0.00% 10 Missing ⚠️
internal/services/domain/helpers.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3596      +/-   ##
=========================================
- Coverage    2.34%   2.33%   -0.02%     
=========================================
  Files         445     445              
  Lines       48555   48557       +2     
=========================================
- Hits         1140    1132       -8     
- Misses      47325   47334       +9     
- Partials       90      91       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mauritsderuiter95
Copy link
Contributor Author

After a rebase on master the golanci-lint is failing on unrelated code. I believe ##3597 has the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain Domains issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persistent drift in SRV record with multiple segments

2 participants