-
Notifications
You must be signed in to change notification settings - Fork 133
fix: use dns zone to deduplicate SRV records #3596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: use dns zone to deduplicate SRV records #3596
Conversation
d041396 to
9326015
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3596 +/- ##
=========================================
- Coverage 2.34% 2.33% -0.02%
=========================================
Files 445 445
Lines 48555 48557 +2
=========================================
- Hits 1140 1132 -8
- Misses 47325 47334 +9
- Partials 90 91 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a84f636 to
cde08f9
Compare
008d39d to
e5d18ed
Compare
|
After a rebase on master the golanci-lint is failing on unrelated code. I believe ##3597 has the same issue. |
close #3592
Proposal as described here: #3592 (comment)