Skip to content

Fix dead-task when skip in notification processor #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

francoisferrand
Copy link
Contributor

Backport from #2653

Issue: BB-693

@bert-e
Copy link
Contributor

bert-e commented Jun 26, 2025

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.36%. Comparing base (5e83f3b) to head (135f9eb).
Report is 2 commits behind head on hotfix/9.0.4.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...ions/notification/queueProcessor/QueueProcessor.js 56.86% <100.00%> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 75.37% <100.00%> (ø)
Core Library 80.18% <ø> (-0.23%) ⬇️
Ingestion 70.23% <ø> (ø)
Lifecycle 77.08% <ø> (ø)
Oplog Populator 85.06% <ø> (ø)
Replication 58.60% <ø> (ø)
Bucket Scanner 85.60% <ø> (ø)
@@               Coverage Diff                @@
##           hotfix/9.0.4    #2654      +/-   ##
================================================
- Coverage         73.45%   73.36%   -0.09%     
================================================
  Files               201      201              
  Lines             13374    13374              
================================================
- Hits               9824     9812      -12     
- Misses             3540     3552      +12     
  Partials             10       10              
Flag Coverage Δ
api:retry 9.48% <0.00%> (ø)
api:routes 9.29% <0.00%> (ø)
bucket-scanner 85.60% <ø> (ø)
ft_test:queuepopulator 10.17% <0.00%> (-0.54%) ⬇️
ingestion 12.56% <0.00%> (ø)
lib 7.33% <0.00%> (ø)
lifecycle 18.75% <0.00%> (ø)
notification 1.06% <0.00%> (ø)
replication 18.53% <0.00%> (-0.09%) ⬇️
unit 48.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@francoisferrand
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Jun 26, 2025
@scality scality deleted a comment from bert-e Jun 26, 2025
@bert-e
Copy link
Contributor

bert-e commented Jun 26, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ hotfix/9.0.4

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/9.0
  • development/9.1

Please check the status of the associated issue BB-693.

Goodbye francoisferrand.

The following options are set: approve

@bert-e bert-e merged commit 135f9eb into hotfix/9.0.4 Jun 26, 2025
13 of 14 checks passed
@bert-e bert-e deleted the bugfix/BB-693-backport-9.0.4 branch June 26, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants