Fix handling of buckets with disabled bucket notifications #2656

Kerkesni · 2025-07-07T13:54:27Z

Backport #2655

bert-e · 2025-07-07T13:54:30Z

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-07-07T13:54:35Z

Incorrect fix version

The Fix Version/s in issue BB-697 contains:

9.0.13
9.1.0

Considering where you are trying to merge, I expected to find at least:

9.0.4.2

Please check the Fix Version/s of BB-697, or the target
branch of this pull request.

codecov · 2025-07-07T14:08:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.00%. Comparing base (135f9eb) to head (21cb21f).
Report is 4 commits behind head on hotfix/9.0.4.

Additional details and impacted files

Files with missing lines	Coverage Δ
...ensions/notification/NotificationQueuePopulator.js	`98.13% <100.00%> (+0.05%)`	⬆️
...s/notification/configManager/MongoConfigManager.js	`97.87% <100.00%> (+0.07%)`	⬆️

... and 5 files with indirect coverage changes

Components	Coverage Δ
Bucket Notification	`75.57% <100.00%> (+0.19%)`	⬆️
Core Library	`79.41% <ø> (-0.78%)`	⬇️
Ingestion	`70.14% <ø> (-0.09%)`	⬇️
Lifecycle	`76.88% <ø> (-0.21%)`	⬇️
Oplog Populator	`85.06% <ø> (ø)`
Replication	`58.56% <ø> (-0.04%)`	⬇️
Bucket Scanner	`85.60% <ø> (ø)`

@@               Coverage Diff                @@
##           hotfix/9.0.4    #2656      +/-   ##
================================================
- Coverage         73.36%   73.00%   -0.37%     
================================================
  Files               201      201              
  Lines             13374    13380       +6     
================================================
- Hits               9812     9768      -44     
- Misses             3552     3602      +50     
  Partials             10       10

Flag	Coverage Δ
api:retry	`9.47% <0.00%> (-0.01%)`	⬇️
api:routes	`9.29% <0.00%> (-0.01%)`	⬇️
bucket-scanner	`85.60% <ø> (ø)`
ft_test:queuepopulator	`8.90% <0.00%> (-1.28%)`	⬇️
ingestion	`12.55% <0.00%> (-0.02%)`	⬇️
lib	`7.33% <0.00%> (-0.01%)`	⬇️
lifecycle	`18.74% <0.00%> (-0.01%)`	⬇️
notification	`1.07% <9.52%> (+<0.01%)`	⬆️
replication	`18.52% <0.00%> (-0.01%)`	⬇️
unit	`48.58% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

williamlardier

Please backport the latest changes before merging 🙂

Kerkesni · 2025-07-08T13:24:21Z

~~Closing PR as no release of ARTESCA 3.1.3 is currently planned.~~

Added try/catch to _processObjectEntry to catch exception and log them before returning an error Issue: BB-697

When bucket notifications are disabled after being enabled, the configuration is set to an empty object. Previously, this case was not handled properly, leading to crashes as the notification producer and processor incorrectly considered the configuration available. This fix ensures proper handling of empty configurations to prevent such issues. Issue: BB-697

bert-e · 2025-07-17T11:27:48Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

Kerkesni · 2025-07-17T11:38:38Z

/approve

bert-e · 2025-07-17T11:48:53Z

Build failed

The build for commit did not succeed in branch bugfix/BB-697-backport-9.0.4

The following options are set: approve

Debian Buster repositories are no longer available. Debian Buster reached end-of-life and has been moved to archive repositories Issue: BB-697

Issue: BB-697

bert-e · 2025-07-17T12:34:26Z

Build failed

The build for commit did not succeed in branch bugfix/BB-697-backport-9.0.4

The following options are set: approve

bert-e · 2025-07-17T14:04:46Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ hotfix/9.0.4

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.6
development/9.0
development/9.1

Please check the status of the associated issue BB-697.

Goodbye kerkesni.

The following options are set: approve

Kerkesni requested review from SylvainSenechal, williamlardier and benzekrimaha July 7, 2025 14:01

williamlardier approved these changes Jul 8, 2025

View reviewed changes

Kerkesni force-pushed the bugfix/BB-697-backport-9.0.4 branch 2 times, most recently from 5d0588a to 313bb9b Compare July 8, 2025 10:17

Kerkesni closed this Jul 8, 2025

Kerkesni reopened this Jul 17, 2025

Kerkesni added 2 commits July 17, 2025 13:25

Fix error handling fallback in _processObjectEntry

b1f1976

Added try/catch to _processObjectEntry to catch exception and log them before returning an error Issue: BB-697

Kerkesni force-pushed the bugfix/BB-697-backport-9.0.4 branch from 313bb9b to 096dbd3 Compare July 17, 2025 11:26

benzekrimaha approved these changes Jul 17, 2025

View reviewed changes

Kerkesni force-pushed the bugfix/BB-697-backport-9.0.4 branch 2 times, most recently from 6440bf9 to 6d18072 Compare July 17, 2025 12:12

Kerkesni added 2 commits July 17, 2025 14:21

fix ft tests

26a6c7f

Debian Buster repositories are no longer available. Debian Buster reached end-of-life and has been moved to archive repositories Issue: BB-697

bump version to 9.0.4.2

21cb21f

Issue: BB-697

Kerkesni force-pushed the bugfix/BB-697-backport-9.0.4 branch from 6d18072 to 21cb21f Compare July 17, 2025 12:22

bert-e merged commit 21cb21f into hotfix/9.0.4 Jul 17, 2025
25 of 30 checks passed

bert-e deleted the bugfix/BB-697-backport-9.0.4 branch July 17, 2025 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix handling of buckets with disabled bucket notifications #2656

Fix handling of buckets with disabled bucket notifications #2656

Uh oh!

Kerkesni commented Jul 7, 2025

Uh oh!

bert-e commented Jul 7, 2025

Uh oh!

bert-e commented Jul 7, 2025

Uh oh!

codecov bot commented Jul 7, 2025 •

edited

Loading

Uh oh!

williamlardier left a comment •

edited

Loading

Uh oh!

Kerkesni commented Jul 8, 2025 •

edited

Loading

Uh oh!

bert-e commented Jul 17, 2025

Uh oh!

Kerkesni commented Jul 17, 2025

Uh oh!

bert-e commented Jul 17, 2025

Uh oh!

bert-e commented Jul 17, 2025

Uh oh!

bert-e commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

Fix handling of buckets with disabled bucket notifications #2656

Fix handling of buckets with disabled bucket notifications #2656

Uh oh!

Conversation

Kerkesni commented Jul 7, 2025

Uh oh!

bert-e commented Jul 7, 2025

Hello kerkesni,

Uh oh!

bert-e commented Jul 7, 2025

Incorrect fix version

Uh oh!

codecov bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

williamlardier left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kerkesni commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Jul 17, 2025

Waiting for approval

Uh oh!

Kerkesni commented Jul 17, 2025

Uh oh!

bert-e commented Jul 17, 2025

Build failed

Uh oh!

bert-e commented Jul 17, 2025

Build failed

Uh oh!

bert-e commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 7, 2025 •

edited

Loading

williamlardier left a comment •

edited

Loading

Kerkesni commented Jul 8, 2025 •

edited

Loading