BB-694: Update auth config schema by tmacro · Pull Request #2659 · scality/backbeat

tmacro · 2025-07-15T02:30:30Z

Extends the existing schema to support basic auth and stricter checking of kerberos.

bert-e · 2025-07-15T02:30:34Z

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

codecov · 2025-07-15T15:19:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.39%. Comparing base (2abfc06) to head (ead9d77).
Report is 2 commits behind head on development/9.0.

Additional details and impacted files

Files with missing lines	Coverage Δ
...nsions/notification/NotificationConfigValidator.js	`100.00% <100.00%> (ø)`
...tensions/notification/destination/KafkaProducer.js	`100.00% <100.00%> (ø)`
extensions/notification/index.js	`75.00% <100.00%> (ø)`

... and 2 files with indirect coverage changes

Components	Coverage Δ
Bucket Notification	`76.47% <100.00%> (+1.00%)`	⬆️
Core Library	`79.67% <ø> (-0.02%)`	⬇️
Ingestion	`70.14% <ø> (ø)`
Lifecycle	`77.94% <ø> (ø)`
Oplog Populator	`85.06% <ø> (ø)`
Replication	`58.55% <ø> (ø)`
Bucket Scanner	`85.60% <ø> (ø)`

@@                 Coverage Diff                 @@
##           development/9.0    #2659      +/-   ##
===================================================
+ Coverage            73.34%   73.39%   +0.04%     
===================================================
  Files                  201      201              
  Lines                13387    13393       +6     
===================================================
+ Hits                  9819     9830      +11     
+ Misses                3558     3553       -5     
  Partials                10       10

Flag	Coverage Δ
api:retry	`9.50% <80.00%> (+0.03%)`	⬆️
api:routes	`9.32% <80.00%> (+0.03%)`	⬆️
bucket-scanner	`85.60% <ø> (ø)`
ft_test:queuepopulator	`8.94% <80.00%> (+0.03%)`	⬆️
ingestion	`12.58% <80.00%> (+0.03%)`	⬆️
lib	`7.41% <80.00%> (+0.02%)`	⬆️
lifecycle	`18.80% <80.00%> (+0.02%)`	⬆️
notification	`1.05% <0.00%> (-0.01%)`	⬇️
replication	`18.56% <80.00%> (+0.02%)`	⬆️
unit	`49.05% <100.00%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bert-e · 2025-07-15T15:20:37Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

tmacro · 2025-07-15T15:21:46Z

/create_integration_branches

bert-e · 2025-07-15T15:24:19Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

tests/unit/notification/NotificationConfigValidator.js

jonathan-gramain · 2025-07-18T00:08:10Z

extensions/notification/NotificationConfigValidator.js

-    ssl: joi.boolean(),
-    protocol: joi.string(),
+const sslSchema = joi.object({
+    ssl: joi.boolean().default(false),


Would having type: "ssl" be more consistent with the other auth types?

The ssl auth isn't really a distinct type, it can be used with kerberos and basic auth as well. My feeling is most deploys using kerberos and basic auth will use at least ca and key so the credentials aren't sent over the wire unencrypted.

bert-e · 2025-07-18T20:08:18Z

History mismatch

Merge commit #7d38f2312d9a31a7851ede0cd3c7cd7a5508f9e2 on the integration branch
w/9.1/improvement/BB-694/update_auth_config_schema is merging a branch which is neither the current
branch improvement/BB-694/update_auth_config_schema nor the development branch
development/9.1.

It is likely due to a rebase of the branch improvement/BB-694/update_auth_config_schema and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

tmacro · 2025-07-18T20:09:01Z

/reset

bert-e · 2025-07-18T20:09:10Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2025-07-18T20:11:35Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

bert-e · 2025-07-21T17:55:35Z

Build failed

The build for commit did not succeed in branch w/9.1/improvement/BB-694/update_auth_config_schema

The following options are set: approve, create_integration_branches

bert-e · 2025-07-21T18:26:06Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/9.0
✔️ development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

bert-e · 2025-07-21T19:00:35Z

Queue build failed

The corresponding build for the queue failed:

Checkout the status page.
Identify the failing build and review the logs.
If no issue is found, re-run the build.
If an issue is identified, checkout the steps below to remove
the pull request from the queue for further analysis and maybe rebase/merge.

Remove the pull request from the queue

Add a /wait comment on this pull request.
Click on login on the status page.
Go into the manage page.
Find the option called Rebuild the queue and click on it.
Bert-E will loop again on all pull requests to put the valid ones
in the queue again, while skipping the one with the /wait comment.
Wait for the new queue to merge, then merge/rebase your pull request
with the latest changes to then work on a proper fix.
Once the issue is fixed, delete the /wait comment and
follow the usual process to merge the pull request.

bert-e · 2025-07-21T19:53:53Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches, wait

bert-e · 2025-07-21T19:57:51Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

tmacro · 2025-07-21T19:58:08Z

/approve

bert-e · 2025-07-21T20:27:45Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.0
✔️ development/9.1

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.6

Please check the status of the associated issue BB-694.

Goodbye tmacro.

The following options are set: approve, create_integration_branches

tmacro force-pushed the improvement/BB-694/update_auth_config_schema branch from 1b5e9f3 to 34a1825 Compare July 15, 2025 15:19

scality deleted a comment from bert-e Jul 15, 2025

tmacro changed the title ~~BB-695: Update auth config schema~~ BB-694: Update auth config schema Jul 15, 2025

tcarmet approved these changes Jul 16, 2025

View reviewed changes

jonathan-gramain approved these changes Jul 18, 2025

View reviewed changes

BourgoisMickael approved these changes Jul 18, 2025

View reviewed changes

nicolas2bert approved these changes Jul 18, 2025

View reviewed changes

tmacro force-pushed the improvement/BB-694/update_auth_config_schema branch from d51787a to 4f5c717 Compare July 18, 2025 20:08

scality deleted a comment from bert-e Jul 18, 2025

scality deleted a comment from bert-e Jul 21, 2025

tmacro added 2 commits July 21, 2025 12:51

impr(BB-694): Add schemas for kerberos and basic auth configs

150f39c

Bump CI cloudserver tag to 9.0.19

ead9d77

tmacro force-pushed the improvement/BB-694/update_auth_config_schema branch from 4f5c717 to ead9d77 Compare July 21, 2025 19:53

scality deleted a comment from bert-e Jul 21, 2025

bert-e merged commit ead9d77 into development/9.0 Jul 21, 2025
10 checks passed

bert-e deleted the improvement/BB-694/update_auth_config_schema branch July 21, 2025 20:27

Conversation

tmacro commented Jul 15, 2025

Uh oh!

bert-e commented Jul 15, 2025

Hello tmacro,

Uh oh!

codecov bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bert-e commented Jul 15, 2025

Request integration branches

Uh oh!

tmacro commented Jul 15, 2025

Uh oh!

bert-e commented Jul 15, 2025

Waiting for approval

Uh oh!

Uh oh!

jonathan-gramain Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

tmacro Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

bert-e commented Jul 18, 2025

History mismatch

Uh oh!

tmacro commented Jul 18, 2025

Uh oh!

bert-e commented Jul 18, 2025

Reset complete

Uh oh!

bert-e commented Jul 18, 2025

Waiting for approval

Uh oh!

bert-e commented Jul 21, 2025

Build failed

Uh oh!

bert-e commented Jul 21, 2025

In the queue

Uh oh!

bert-e commented Jul 21, 2025

Queue build failed

Uh oh!

bert-e commented Jul 21, 2025

Reset complete

Uh oh!

bert-e commented Jul 21, 2025

Waiting for approval

Uh oh!

tmacro commented Jul 21, 2025

Uh oh!

Uh oh!

bert-e commented Jul 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jul 15, 2025 •

edited

Loading