BB-694: Update auth config schema #2659
Open
+251
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello tmacro,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
tmacro
force-pushed
the
improvement/BB-694/update_auth_config_schema
branch
from
1b5e9f3 to
34a1825
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 4 files with indirect coverage changes
@@ Coverage Diff @@
## development/9.0 #2659 +/- ##
===================================================
+ Coverage 73.35% 73.65% +0.30%
===================================================
Files 201 201
Lines 13390 13396 +6
===================================================
+ Hits 9822 9867 +45
+ Misses 3558 3519 -39
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
/create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
tmacro
changed the title
tcarmet
approved these changes
Jul 16, 2025
jonathan-gramain
approved these changes
Jul 18, 2025
| destinations: [{ | ||
| const testCases = [ | ||
| { | ||
| valid:false, |
There was a problem hiding this comment.
Suggested change
| valid:false, | |
| valid: false, |
| ssl: joi.boolean(), | ||
| protocol: joi.string(), | ||
| const sslSchema = joi.object({ | ||
| ssl: joi.boolean().default(false), |
There was a problem hiding this comment.
Would having type: "ssl" be more consistent with the other auth types?
BourgoisMickael
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the existing schema to support basic auth and stricter checking of kerberos.